Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Php81] Skip $this::class on trait on NullToStrictStringFuncCallArgRector #5732

Merged
merged 1 commit into from
Mar 17, 2024
Merged

[Php81] Skip $this::class on trait on NullToStrictStringFuncCallArgRector #5732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...r/FuncCall/NullToStrictStringFuncCallArgRector/Fixture/skip_class_string_on_trait.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?php

namespace Rector\Tests\Php81\Rector\FuncCall\NullToStrictStringFuncCallArgRector\Fixture;

trait SkipClassStringOnTrait
{
public function run(string $param)
{
return str_replace($param, '', $this::class);
}
}
4 changes: 4 additions & 0 deletions rules/Php81/Rector/FuncCall/NullToStrictStringFuncCallArgRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,10 @@ private function shouldSkipTrait(Expr $expr, Type $type, bool $isTrait): bool
return false;
}

if ($type instanceof ErrorType) {
return true;
}

if ($type->isExplicitMixed()) {
return false;
}
Expand Down