Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeDeclaration] Add If else assign support on TypedPropertyFromAssignsRector #5314

Merged
merged 12 commits into from
Dec 3, 2023
Merged

[TypeDeclaration] Add If else assign support on TypedPropertyFromAssignsRector #5314

merged 12 commits into from
Dec 3, 2023

Conversation

samsonasik
Copy link
Member

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @staabm

@samsonasik samsonasik mentioned this pull request Dec 3, 2023
Closed
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit be924be into main Dec 3, 2023
41 checks passed
@TomasVotruba TomasVotruba deleted the add-if-else-2 branch December 3, 2023 11:16
@TomasVotruba
Copy link
Member

This looks great, thank you 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect behavior of TypedPropertyFromAssignsRector
3 participants
@samsonasik @TomasVotruba @actions-user