Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Privatization] Skip call non-private method on non-final class on PrivatizeLocalGetterToPropertyRector #5309

Merged
merged 3 commits into from
Dec 2, 2023
Merged

[Privatization] Skip call non-private method on non-final class on PrivatizeLocalGetterToPropertyRector #5309

merged 3 commits into from
Dec 2, 2023

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Dec 2, 2023 •
edited
Loading

Non private method can be overriden by child, so should be skipped, it currently just call the property:

Ref https://getrector.com/demo/399a6e14-4976-4137-9f4f-b2f545979fdf

which should be skipped.

@samsonasik
Copy link
Member Author

Fixed 🎉

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit aac9573 into main Dec 2, 2023
41 checks passed
@samsonasik samsonasik deleted the skip-non-private branch December 2, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samsonasik