Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EarlyReturn] Skip duplicating complex expression in ChangeAndIfToEarlyReturnRector #5301

Merged
merged 1 commit into from
Nov 30, 2023
Merged

[EarlyReturn] Skip duplicating complex expression in ChangeAndIfToEarlyReturnRector #5301

merged 1 commit into from
Nov 30, 2023

Conversation

TomasVotruba
Copy link
Member

No description provided.

@TomasVotruba TomasVotruba force-pushed the tv-skip-complex-early-returns branch from 676b33e to 7a7a093 Compare November 30, 2023 08:48
@TomasVotruba TomasVotruba force-pushed the tv-skip-complex-early-returns branch from 7a7a093 to e6ba660 Compare November 30, 2023 08:52
@TomasVotruba TomasVotruba enabled auto-merge (squash) November 30, 2023 08:52
@TomasVotruba TomasVotruba merged commit 0317e67 into main Nov 30, 2023
41 checks passed
@TomasVotruba TomasVotruba deleted the tv-skip-complex-early-returns branch November 30, 2023 08:53
@samsonasik
Copy link
Member

@TomasVotruba build scoped error seems due to latest symfony console 6.4:

https://github.com/rectorphp/rector-src/actions/runs/7044121745/job/19171186107#step:14:64

I think we can use ~6.3.9 for quick fix

@samsonasik
Copy link
Member

I created PR for it:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomasVotruba @samsonasik