Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Naming] Skip singularize "cms" on RenameForeachValueVariableToMatchExprVariableRector #5294

Merged
merged 2 commits into from
Nov 28, 2023
Merged

[Naming] Skip singularize "cms" on RenameForeachValueVariableToMatchExprVariableRector #5294

merged 2 commits into from
Nov 28, 2023

Conversation

samsonasik
Copy link
Member

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @zukovasmartynas

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 4a2b4a6 into main Nov 28, 2023
41 checks passed
@samsonasik samsonasik deleted the skip-cms-part branch November 28, 2023 04:41
@zukovasmartynas
Copy link

Thank you for such a rapid response and a fix

@samsonasik samsonasik mentioned this pull request Dec 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Renaming suggestion from rector is a bit strange
2 participants
@samsonasik @zukovasmartynas