[PHP83] Implements a rule to add types to class constants

[peterfox]

With PHP 8.3 being released I thought I'd add another rule. This time for Types Class Constants.

The rule will change classes, traits and interfaces that contain constants.

The behavior of this rule is limited to mostly the type being obvious.

• The rule won't try to detect types based on operations.
• The rule won't apply if a parent class has the constant, or an interface extending interfaces.
• The rule won't apply if a trait being used has the constant.
• The rule won't try to override anything for instance if the type is a union already.
• The rule won't apply if referencing another constant.

Some of these scenarios could be added over time but it makes sense to at least have a start that picks up the basics.

[TomasVotruba]

Hi, thanks for kicking of this PHP 8.3 rule. I look foward to it for many years.

Let's ship it so we can test and iterate improvements 👍

[pepeh]

This rule is broken when you have private and then public const:

<?php

class Test
{
    private const A = 1000;
    public const B = 'foo';
    public const C = 'bar';
}

will be changed to

<?php

class Test
{
    private const int A = 1000;
    public const int B = 'foo'; // int?
    public const int C = 'bar';
}

And when first variable is public, then it applied to private only.

<?php

class Test
{
    public const A = 1000;
    private const string B = 'foo';
    private const string  C = 'bar';
}

[peterfox]

Will take a look into this.