Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeQuality] Handle negated isset on IssetOnPropertyObjectToPropertyExistsRector on property not exists #5206

Merged
merged 4 commits into from
Oct 27, 2023
Merged

[CodeQuality] Handle negated isset on IssetOnPropertyObjectToPropertyExistsRector on property not exists #5206

merged 4 commits into from
Oct 27, 2023

Conversation

samsonasik
Copy link
Member

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @pedrobrazao

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit a273705 into main Oct 27, 2023
41 checks passed
@samsonasik samsonasik deleted the negated-isset branch October 27, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect behavior of IssetOnPropertyObjectToPropertyExistsRector
2 participants
@samsonasik @actions-user