Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix phpstan notice $phpVersion on Rector\Config\RectorConfig::phpVersion() #5193

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Fix phpstan notice $phpVersion on Rector\Config\RectorConfig::phpVersion() #5193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f14963
Fix phpstan notice $phpVersion on Rector\Config\RectorConfig::phpVers…
samsonasik Oct 23, 2023
a294884
add value
samsonasik Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ parameters:
- rules/EarlyReturn/Rector/If_/ChangeAndIfToEarlyReturnRector.php

# known value
- '#Method Rector\\Core\\Php\\PhpVersionProvider\:\:provide\(\) should return 50200\|50300\|50400\|50500\|50600\|70000\|70100\|70200\|70300\|70400\|80000\|80100\|80200\|100000 but returns int#'
- '#Method Rector\\Core\\Php\\PhpVersionProvider\:\:provide\(\) should return 50200\|50300\|50400\|50500\|50600\|70000\|70100\|70200\|70300\|70400\|80000\|80100\|80200\|80300\|100000 but returns int#'

# stubs-rector directory exists on target-repository
-
Expand Down Expand Up @@ -412,7 +412,7 @@ parameters:
path: utils/ChangelogGenerator

-
message: '#Parameter \#1 \$phpVersion of method Rector\\Config\\RectorConfig\:\:phpVersion\(\) expects 50200\|50300\|50400\|50500\|50600\|70000\|70100\|70200\|70300\|70400\|80000\|80100\|80200\|100000, (.*?) given#'
message: '#Parameter \#1 \$phpVersion of method Rector\\Config\\RectorConfig\:\:phpVersion\(\) expects 50200\|50300\|50400\|50500\|50600\|70000\|70100\|70200\|70300\|70400\|80000\|80100\|80200\|80300\|100000, (.*?) given#'
path: rules-tests

-
Expand Down
5 changes: 5 additions & 0 deletions src/ValueObject/PhpVersion.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,11 @@ final class PhpVersion
*/
public const PHP_82 = 80200;

/**
* @var int
*/
public const PHP_83 = 80300;

/**
* @var int
*/
Expand Down