[TypeDeclaration] Handle skipped by file path on DeclareStrictTypesRector due to use beforeTraverse() #5191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Fixed 🎉 /cc @kenjis |
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
Comment on lines
54
to
+59
| parent::beforeTraverse($nodes); | ||
|
|
||
| $filePath = $this->file->getFilePath(); | ||
| if ($this->skipper->shouldSkipElementAndFilePath(self::class, $filePath)) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
This should be moved to AbstractRector::beforeTraverse() or similar, as rector rule itself should not decide about the sip.
There was a problem hiding this comment.
It can't, as AbstractRector::beforeTraverse() on setup File object, and re-called early in current parent::beforeTraverse(), moving to AbstractRector will require parent::beforeTraverse() to not called early, but after.
There was a problem hiding this comment.
I see. Let's go for it now then.
Bbut in case more rules will need the skip fix, we'll have to move it to single place outside specific rules.
|
Thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kenjis this is for bug you found on CodeIgniter PR:
declare(strict_types=1)codeigniter4/CodeIgniter4#8072 (comment)which
DeclareStrictTypesRectordue to usebeforeTraverse()instead ofenterNode(), while onAbstractRector, checking skip is byenterNode()so it overlapped.