RemoveUnusedNonEmptyArrayBeforeForeachRector: skip array dim fetch #5166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Oct 14, 2023
|
|
||
| public static function getFootnotes($group = self::DEFAULT_GROUP): array | ||
| { | ||
| if (! empty(self::$groups[$group])) { |
There was a problem hiding this comment.
since we already skip "regular" dim fetch, I think it makes sense to also skip it for this example
There was a problem hiding this comment.
is it possible to to check native ArrayDimFetch type for this case?
if ($foreachExpr instanceof Expr\ArrayDimFetch) {
$nativeType = $this->nodeTypeResolver-getNativeType(...
}There was a problem hiding this comment.
Do you have a test case in mind which fails atm?
There was a problem hiding this comment.
something like assign in prev stmt:
self::$groups[$group] = ["foo"];
if (! empty(self::$groups[$group]))There was a problem hiding this comment.
could you fix phpstan notice? thank you.
There was a problem hiding this comment.
good catch :-). fixed.
|
Thank you @staabm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes rectorphp/rector#8264