[DeadCode] Add RemoveUselessReturnExprInConstructRector

[samsonasik]

@TomasVotruba @staabm here new rule to remove useless Return Expr in construct:

 class SomeClass
 {
     public function __construct()
     {
         if (rand(0, 1)) {
             $this->init();
-            return true;
+            return;
         }

         if (rand(2, 3)) {
-            return parent::construct();
+            parent::construct();
+            return;
         }

         $this->execute();
     }
 }

[samsonasik]

All checks have passed 🎉 @TomasVotruba I think it is ready.

[staabm]

awesome

[samsonasik]

It seems it can cause a bug if it call a method call, eg:

return parent::__construct();

which should be :

-return parent::__construct();
+parent::__construct();
+return;

so use its Expr to Expression for that case

[TomasVotruba]

Looks good 👍 Feel free to merge when ready

[samsonasik]

I added fixture for return dynamic Expr 1e79d54

[samsonasik]

Implemented, I added ability to CallableNodeVisitor to allow return array of Node (it Stmt[] obviously, but mark as Node[] to ensure same signature with what in AbstractRector), to allow replace single node to multi nodes on usage:

-return parent::__construct();
+parent::__construct();
+return;

with SimpleCallableNodeTraverser c1f0717

[samsonasik]

All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;)

[TomasVotruba]

👏