Remove src/constants.php for T_ENUM and T_NAME_RELATIVE #5143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TomasVotruba packages tests error seems due to the "files" is loaded too early PHP Warning: require(/home/runner/work/rector-src/rector-src/vendor/composer/../rector/rector-src/src/constants.php): Failed to open stream: No such file or directory in /home/runner/work/rector-src/rector-src/vendor/composer/autoload_real.php on line 41https://github.com/rectorphp/rector-src/actions/runs/6446174604/job/17501018964?pr=5143#step:7:10 that this may need to be merged first |
|
Let's try this one 🙂 |
samsonasik
added a commit
that referenced
this pull request
Oct 10, 2023
* Remove src/constants.php * remove include
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The register was happen 2 years ago:
ac7a03f
due to nikic/php-parser
4.10.5, which reportered on issue:which seems now already registered on
defineCompatibilityTokens()method:https://github.com/nikic/PHP-Parser/blob/a6303e50c90c355c7eeee2c4a8b27fe8dc8fef1d/lib/PhpParser/Lexer.php#L438-L443
Based on that, it seems we no longer require to add it so it seems src/constants.php no longer needed.