Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PhpParser] Reduce AstResolver complexity by move check fileName is null to parseFileNameToDecoratedNodes() #5138

Merged
merged 4 commits into from
Oct 7, 2023
Merged

[PhpParser] Reduce AstResolver complexity by move check fileName is null to parseFileNameToDecoratedNodes() #5138

merged 4 commits into from
Oct 7, 2023

Conversation

samsonasik
Copy link
Member

No description provided.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready.

@samsonasik
Copy link
Member Author

I also removed ClassLikeAstResolver as used internally by AstResolver by move the code block to AstResolver itself, and remove useless empty stmts result on a File as lessly happen.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready.

@TomasVotruba
Copy link
Member

Amazing cleanup, thanks a lot 👏

@TomasVotruba TomasVotruba merged commit d320ac7 into main Oct 7, 2023
41 checks passed
@TomasVotruba TomasVotruba deleted the reduce-complexity-ast-resolver branch October 7, 2023 10:16
samsonasik added a commit that referenced this pull request Oct 10, 2023
@samsonasik
[PhpParser] Reduce AstResolver complexity by move check fileName is n…
d4dc408 
…ull to parseFileNameToDecoratedNodes() (#5138)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @TomasVotruba