Allow namespace import to be resolved #5123
Conversation
| /** | ||
| * @var float | ||
| * | ||
| * @FixtureAnnotation\CustomAnnotation() |
There was a problem hiding this comment.
it seems need a test with \ prefix for fqcn ensure for:
* @\FixtureAnnotation\CustomAnnotation()
ensure that different namespace for FQCN?
There was a problem hiding this comment.
Not sure I understand, is annotation starting with @\ exists ?
There was a problem hiding this comment.
Yes, annotation work with @\ usage as FQCN
| use Rector\Testing\TestingParser\TestingParser; | ||
| use Rector\Tests\CodingStyle\NodeAnalyzer\UseImportNameMatcher\Fixture\FixtureAnnotation\CustomAnnotation; | ||
|
|
||
| class UseImportNameMatcherTest extends AbstractLazyTestCase |
There was a problem hiding this comment.
I prefer real rules() usage instead of creating new test class, as it hard to debug, you can add more test with specific config under tests/Issues
https://github.com/rectorphp/rector-src/tree/main/tests/Issues
and add fixture with expected output with config there.
There was a problem hiding this comment.
Sure I'll need to see how to do what you ask.
I'll take a look to the otheres tests.
|
Handled at #5287 |
fix rectorphp/rector#8224
I didn't run tests for
rector/symfonyrector\doctrine, etc. hope it won't break anything there.Like discussed in the issue, I removed the
class_existscheck