Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeDeclaration] Skip ArrayDimFetch for return and param types #5059

Merged
merged 2 commits into from
Sep 21, 2023
Merged

[TypeDeclaration] Skip ArrayDimFetch for return and param types #5059

merged 2 commits into from
Sep 21, 2023

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Sep 21, 2023 •
edited
Loading

as proposed in #5056 (comment)

@staabm staabm changed the title Added more phpdoc array shape tests [TypeDeclaration] Skip ArrayDimFetch for return and param types Sep 21, 2023
@staabm
Copy link
Contributor Author

staabm commented Sep 21, 2023

@samsonasik please see the failing tests

@samsonasik
Copy link
Member

should be covered by #5058, please rebase

@samsonasik
Copy link
Member

It seems green, I am merging it ;)

@samsonasik samsonasik merged commit 84916ed into rectorphp:main Sep 21, 2023
37 checks passed
@staabm staabm deleted the shape-tests branch September 21, 2023 13:37
@staabm
Copy link
Contributor Author

staabm commented Sep 21, 2023

Excellent - thanks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik left review comments

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@staabm @samsonasik