Trigger Rectify

[samsonasik]

Trigger rectify from changes:

• UseImportsTraverser: don't deep traverse #4994

[staabm]

thats wrong. I intentionally left that out

[staabm]

since our logic here already traverses into such nodes, the traverser itself doesn't need todo it a second time

[samsonasik]

ok, reverted, I will test in other projects :)

[samsonasik]

@staabm I am testing it, it cause overlapped type

diff --git a/rules/CodingStyle/ClassNameImport/ClassNameImportSkipper.php b/rules/CodingStyle/ClassNameImport/ClassNameImportSkipper.php
index 7e3b49fa0f..25e5d6c605 100644
--- a/rules/CodingStyle/ClassNameImport/ClassNameImportSkipper.php
+++ b/rules/CodingStyle/ClassNameImport/ClassNameImportSkipper.php
@@ -67,7 +67,7 @@ final class ClassNameImportSkipper
     public function isFoundInUse(Name $name, array $uses): bool
     {
         $stringName = $name->toString();
-        $nameLastName = strtolower($name->getLast());
+        $nameLastName = strtolower((string) $name->getLast());

when changing import type :), so return null seems needed, I will. create separate PR :)

[samsonasik]

double run seems resolve it:

1) rules/CodingStyle/ClassNameImport/ClassNameImportSkipper.php:66

    ---------- begin diff ----------
@@ @@
     public function isFoundInUse(Name $name, array $uses): bool
     {
         $stringName = $name->toString();
-        $nameLastName = strtolower((string) $name->getLast());
+        $nameLastName = strtolower($name->getLast());

         foreach ($uses as $use) {
             $prefix = $this->useImportsResolver->resolvePrefix($use);
    ----------- end diff -----------

Applied rules:
 * RecastingRemovalRector

I guess it is a glitch somewhere, actually, return null is fine, as the Use_ and GroupUse actually has limited attributes.

[staabm]

thanks for testing.

would a return null resolve these problems?

[samsonasik]

It doesn't 😁

It probably another problem with detecting type as mixed/errortype when docblock changed, probably related with @TomasVotruba change on:

• Update docblock only when changed, directly in rector rule #4986

which type now immediatelly got mixed when docblock changed

[samsonasik]

@staabm I created new issue for it:

• Incorrect behavior of NullToStrictStringFuncCallArgRector, AddParamTypeSplFixedArrayRector on importNames() enabled. rector#8196

it may wait for @TomasVotruba work on :

• [DocBlock] Update docblock contents right in the rule #4999

for update docblock content right in the rule, which type currently goes mixed.

[staabm]

Thanks 🙏

[samsonasik]

@staabm resolved by PR:

• [DocBlock] Update docblock contents right in the rule #4999

Ref https://getrector.com/demo/ead4b18f-d042-456d-bcdb-3caef53cc16f