[TypeDeclaration] Refactor UnionTypeMapper::narrowBoolType() to allow bool|int|false converted to bool|int #3685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Or not yet, the following code: class NarrowBoolFalse3
{
/**
* @param bool|int|false|int<0, max> $param
* @return bool|int|false
*/
public function go($param)
{
if (rand(0, 1)) {
return rand(0, 1) ? true : false;
}
return 1;
}
}Ref https://phpstan.org/r/abf31a54-b4dc-49a7-9585-d018ee2bc526 still changed to: -public function go($param)
+public function go(bool|int|false $param): bool|intwhich wrong ..., ref https://3v4l.org/KcCIk |
|
Fixed 🎉 |
|
All checks have passed 🎉 @TomasVotruba I think it is ready. |
|
@TomasVotruba I am merging it ;) |
samsonasik
added a commit
that referenced
this pull request
May 8, 2023
… bool|int|false converted to bool|int (#3685) * [TypeDeclaration] Refactor UnionTypeMapper::narrowBoolType() * more fixture * Fixed 🎉 * already unique $phpParserUnionType->types in previous process * early no type check * Revert early no type check This reverts commit f468270. * skip array reverse index on php 7.x * clean up * clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@internalsystemerror @eugeniya-v I am back and forth checking it so we have functionality to keep working, while prevent the infinite loop, and finally seems I am succeed :)