Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test fixture for NewInInitializerRector #3516

Closed
wants to merge 2 commits into from
Closed

Add failing test fixture for NewInInitializerRector #3516

wants to merge 2 commits into from

Conversation

LeoVie
Copy link
Contributor

@LeoVie LeoVie commented Mar 24, 2023

Failing Test for NewInInitializerRector

Based on https://getrector.com/demo/dd5bff80-0789-4aae-b2a3-686c23a3d164

The rule seems to remove property attributes

samsonasik added a commit that referenced this pull request Apr 1, 2023
@samsonasik
Copy link
Member

@LeoVie I cherry-picked your commit at PR #3546

samsonasik added a commit that referenced this pull request Apr 1, 2023
* Add failing test fixture for NewInInitializerRector

# Failing Test for NewInInitializerRector

Based on https://getrector.com/demo/dd5bff80-0789-4aae-b2a3-686c23a3d164

* Update property_with_attributes.php.inc

* Closes #3516

---------

Co-authored-by: Leo Viezens <leo.viezens@web.de>
@LeoVie
Copy link
Contributor Author

LeoVie commented Apr 2, 2023

@LeoVie I cherry-picked your commit at PR #3546

Nice, thank you :)

samsonasik added a commit that referenced this pull request May 8, 2023
* Add failing test fixture for NewInInitializerRector

# Failing Test for NewInInitializerRector

Based on https://getrector.com/demo/dd5bff80-0789-4aae-b2a3-686c23a3d164

* Update property_with_attributes.php.inc

* Closes #3516

---------

Co-authored-by: Leo Viezens <leo.viezens@web.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants