Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Php80] Add typed property Closure support on ClassPropertyAssignToConstructorPromotionRector #3453

Merged
merged 1 commit into from
Mar 4, 2023

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik requested a review from TomasVotruba as a code owner March 4, 2023 00:53
@samsonasik
Copy link
Member Author

implemented /cc @mvhirsch

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit ed16cab into main Mar 4, 2023
@TomasVotruba TomasVotruba deleted the typed-property-closure branch March 4, 2023 08:50
@TomasVotruba
Copy link
Member

Thank you 👍

@mvhirsch
Copy link
Contributor

mvhirsch commented Mar 6, 2023

Thank you!

samsonasik added a commit that referenced this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClassPropertyAssignToConstructorPromotionRector ignores \Closure
3 participants