[CodeQuality] Add Variable support on class arg on InlineIsAInstanceOfRector #3261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
staabm
reviewed
Jan 2, 2023
| */ | ||
| public function run(object $object, string $type) | ||
| { | ||
| return is_a($object, $type); |
There was a problem hiding this comment.
I think you need another test which verifies that is_a() with a non-class-string 2nd arg is skipped
There was a problem hiding this comment.
That's not needed, all variables seems fine
There was a problem hiding this comment.
If there is a bug on variable usage for 2nd arg (class arg) after transformation, then the bug is on the original is_a
|
Very nice improvement :) thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @staabm comment on PR:
This PR add
Variablesupport on transformingis_atoinstanceofonInlineIsAInstanceOfRector, ref https://3v4l.org/WUiel