PHP80 string helpers loose comparison #3246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-Silbernagel
force-pushed
the
Str-helper-non-strict
branch
from
9d28997 to
8606c40
Compare
TomasVotruba
requested changes
Dec 26, 2022
rules-tests/Php80/Rector/Identical/StrEndsWithRector/Fixture/fixture.php.inc
Outdated
Show resolved
Hide resolved
|
I fixed the dependency in |
N-Silbernagel
force-pushed
the
Str-helper-non-strict
branch
from
86cd2dc to
8858387
Compare
|
CI is green now |
TomasVotruba
approved these changes
Dec 29, 2022
|
Thank you 👏 |
|
Happy to contribute. Thank you for the fast feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for loose comparisons in StrContains-, StrEndsWith- and StrStartsWithRector.
I added those loose comparisons to all corresponding test.
The namespaces "Identical" and "NotIdentical" might not be ideal now but I don't think it's worth changing the FQN of the classes.