[Core] Improve performance on AstResolver and ClassLikeAstResolver #3234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we have
isset()
to verify that collection of class/method exists, but that doesn't match when previous search saved asnull
data, eg:rector-src/src/PhpParser/AstResolver.php
Lines 173 to 174 in 84faf29
the
isset()
will always gotfalse
result when it fillnull
value, this PR change to useisset()
early, then applyarray_key_exists
as fallback so it will use thenull
value as is when it found,see https://3v4l.org/JrQ9n