[Core] Improve performance: remove repetitive currentFileProvider->setFile() call on PhpFileProcessor #3213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is already initialization early of
$this->currentFileProvider->setFile($file);
when call:in
parseFileAndDecorateNodes()
method:rector-src/src/Application/FileProcessor/PhpFileProcessor.php
Lines 111 to 113 in 21c9e59
so, next calls no longer needed as already set early.
so:
✔️ Remove 2 unused call
$this->currentFileProvider->setFile($file);
✔️ Remove unused private method that only call another method, just use as is directly:
as it only do that now.