-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt PrivateConstantToSelfRector to work on non-final classes, too #3198
Merged
TomasVotruba
merged 3 commits into
rectorphp:main
from
alfredbez:adapt-ConvertStaticPrivateConstantToSelfRector-to-work-on-non-final-classes-also
Dec 17, 2022
Merged
Adapt PrivateConstantToSelfRector to work on non-final classes, too #3198
TomasVotruba
merged 3 commits into
rectorphp:main
from
alfredbez:adapt-ConvertStaticPrivateConstantToSelfRector-to-work-on-non-final-classes-also
Dec 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs is generated weekly so you don't have too :)
|
samsonasik
reviewed
Dec 14, 2022
alfredbez
force-pushed
the
adapt-ConvertStaticPrivateConstantToSelfRector-to-work-on-non-final-classes-also
branch
from
December 15, 2022 07:33
c16f092
to
1695135
Compare
samsonasik
reviewed
Dec 15, 2022
rules/CodeQuality/Rector/ClassConstFetch/ConvertStaticPrivateConstantToSelfRector.php
Outdated
Show resolved
Hide resolved
alfredbez
force-pushed
the
adapt-ConvertStaticPrivateConstantToSelfRector-to-work-on-non-final-classes-also
branch
from
December 15, 2022 16:15
1695135
to
4815476
Compare
samsonasik
reviewed
Dec 15, 2022
rules/CodeQuality/Rector/ClassConstFetch/ConvertStaticPrivateConstantToSelfRector.php
Outdated
Show resolved
Hide resolved
alfredbez
force-pushed
the
adapt-ConvertStaticPrivateConstantToSelfRector-to-work-on-non-final-classes-also
branch
from
December 15, 2022 16:35
4815476
to
36b84f1
Compare
samsonasik
reviewed
Dec 16, 2022
rules/CodeQuality/Rector/ClassConstFetch/ConvertStaticPrivateConstantToSelfRector.php
Outdated
Show resolved
Hide resolved
…onstantToSelfRector.php Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
samsonasik
reviewed
Dec 16, 2022
rules/CodeQuality/Rector/ClassConstFetch/ConvertStaticPrivateConstantToSelfRector.php
Outdated
Show resolved
Hide resolved
…onstantToSelfRector.php Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
samsonasik
approved these changes
Dec 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since it configurable, it looks good 👍
Thank you 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #3178
Not sure about the change in the markdown files, part of it looks not unrelated to my change, probably someone forgot to generate that on
main
.I'm not sure what to do for code like this:
I might add a check that changes
static
toself
if all child-classes declare it as aprivate
constant.