-
-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Php55] Handle crash on curly parentheses delimiter on PregReplaceEModifierRector #3144
Conversation
Fixed 🎉 /cc @themrwilliams |
It seems not really working, ref https://3v4l.org/P4mPQ#v5.2.17 vs https://3v4l.org/22DeW#v5.2.17, probably skip is the way to go. |
I skipped 8b0e53f |
All checks have passed 🎉 @TomasVotruba it is ready for review. |
Ok, I got the solution by verify |
Proven works 🎉 https://3v4l.org/fqdPZ#v5.4.45 vs https://3v4l.org/Zm16C#v5.5.38 |
.../Rector/FuncCall/PregReplaceEModifierRector/Fixture/skip_curly_parentheses_delimiter.php.inc
Outdated
Show resolved
Hide resolved
Finally, All checks have passed 🎉 @TomasVotruba I think it is ready. |
I added failing fixture e inside regex not as modifier 27a6d4c |
Fixed 🎉 d150be8 |
All checks have passed 🎉 @TomasVotruba I think it is ready. |
Thank you 🙏 |
Given the following code:
it cause crash:
Ref https://getrector.org/demo/d1c86304-9f2a-4614-b636-f9bb1ebdaa16
This PR try to resolve it
Fixes rectorphp/rector#7635