Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TypeDeclaration] Deprecate unreliable AddArrayReturnDocTypeRector, used split strict typed rules instead #3133

Merged
merged 3 commits into from
Nov 30, 2022

Conversation

TomasVotruba
Copy link
Member

No description provided.

@TomasVotruba TomasVotruba force-pushed the tv-less-array-doc branch 2 times, most recently from 424d42b to 5c53703 Compare November 30, 2022 13:18
@TomasVotruba TomasVotruba changed the title [TypeDeclaration] Deprecated unreliable AddArrayReturnDocTypeRector, used split strict typed rules instead [TypeDeclaration] Deprecate unreliable AddArrayReturnDocTypeRector, used split strict typed rules instead Nov 30, 2022
@TomasVotruba TomasVotruba merged commit 64c03bd into main Nov 30, 2022
@TomasVotruba TomasVotruba deleted the tv-less-array-doc branch November 30, 2022 15:10
@samsonasik
Copy link
Member

@TomasVotruba I am not sure about removing it, as it doesn't change return type, only add array docblock, which seems fine

@TomasVotruba
Copy link
Member Author

It adds array doc based on other docblocks, so it spreads possibly invalid values. Instead we should have specific split rules that handle this based on strict values, like we have for param/return/property types.

@samsonasik
Copy link
Member

Ok 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants