Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeDeclaration] Use existing MakePropertyTypedGuard on TypedPropertyFromStrictConstructorRector #3131

Merged
merged 5 commits into from
Nov 30, 2022
Merged

[TypeDeclaration] Use existing MakePropertyTypedGuard on TypedPropertyFromStrictConstructorRector #3131

merged 5 commits into from
Nov 30, 2022

Conversation

samsonasik
Copy link
Member

MakePropertyTypedGuard already cover many handling on forbidden type and used by trait already, so use the service instead.

@samsonasik samsonasik merged commit 7331d04 into main Nov 30, 2022
@samsonasik samsonasik deleted the use-make-property-type-guard branch November 30, 2022 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba TomasVotruba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samsonasik @TomasVotruba @actions-user