Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Improve performance: remove unnecessary loop StmtsAwareInterface to fill Scope on PHPStanNodeScopeResolver #3048

Conversation

samsonasik
Copy link
Member

The loop of StmtsAwareInterface stmts was introduced at PR:

to resolve crash on combination between ExplicitMethodCallOverMagicGetSetRector and ChangeSwitchToMatchRector

By consecutive Rector rule check PR on:

The loop is no longer needed

…ce to fill Scope on PHPStanNodeScopeResolver
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit 21ead88 into main Nov 11, 2022
@TomasVotruba TomasVotruba deleted the improve-performance-remove-loop-stmts-aware-interface-on-scope-resolver branch November 11, 2022 13:30
@TomasVotruba
Copy link
Member

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants