[Php55] Handle crash on ([[:upper:]]+) regex on PregReplaceEModifierRector

[samsonasik]

Given the following code:

class SkipNoModifier
{
    public function run()
    {
        echo preg_replace('([[:upper:]]+)', '_$0', 'FOO');
    }
}

It currently cause crash:

There was 1 error:

1) Rector\Tests\Php55\Rector\FuncCall\PregReplaceEModifierRector\PregReplaceEModifierRectorTest::test with data set #0 ('/Users/samsonasik/www/rector-...hp.inc')
PhpParser\Error: Syntax error, unexpected '$' on line 1

It should be skipped instead.

Fixes rectorphp/rector#7573

[samsonasik]

Fixed 🎉 /cc @jtojnar

[samsonasik]

The issue seems on [[:upper:]]+) detected as modifier.

[samsonasik]

All checks have passed 🎉 @TomasVotruba it is ready for review.

[jtojnar]

Won’t this not handle (…)e now?

[samsonasik]

that seems require separate PR as the modifer can not only e:

echo preg_replace('{[[:upper:]]+}se', '_$0', 'FOO');

which seems needs extra check with e modifier which the change must only remove the e, to be:

echo preg_replace('{[[:upper:]]+}s', '_$0', 'FOO');

Also possibly other use cases for that.

Feel free to provide a different PR for solution for that if you found a solution first for that.

[jtojnar]

Also, other brackets can be used as delimiters, to avoid having to escape the characters in the expression: https://www.php.net/manual/en/regexp.reference.delimiters.php

[samsonasik]

I add more brackets to handle that 7855361

[samsonasik]

All checks have passed 🎉 @TomasVotruba I think it is ready.

[TomasVotruba]

Thank you 👍