NullToStrictStringFuncCallArgRector - Register a few more functions #2994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
approved these changes
Oct 16, 2022
|
Thank you 👏 |
|
np, and while I'm fairly sure they are correct, please feel free to remove/modify as needed :-) And thanks for all your work on Rector, it's really appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #2543, I think these function arguments are relevant.
This was based on some work I did back in December 2021 to identify which parameters no longer accept NULL in PHP 8.1 (source).
The parameters added to my list needed to also accept a space (manually tested each one), and I questioned if it was relevant for a space to be accepted (e.g. constant_name in
define()does not).As an aside, I would rather we didn't have to litter code with
(string), but I didn't exactly get a good response from my NULL Coercion Consistency RFC (discussion).