[Core] AbstractScopeAwareRector is ready to be used in custom rules 🎉 🎉 🎉 #2537
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think
AbstractScopeAwareRector
is now ready to be used in custom rector rule, as the next ofUnreachableStatementNode
is correctly hasScope
now, so on this PR, I remove the@internal
note comment .By this, the tweak of
PropertyFetch
filled outside method which make read after$this->nestingLevel < 2
gotUnreachableStatementNode
onMultiDirnameRector
at PR:can be rolled back as it no longer error on running rectify:
bin/rector process rules/Php70/Rector/FuncCall/MultiDirnameRector.php --dry-run --clear-cache 1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% [OK] Rector is done!
🎉 🎉 🎉