Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] AbstractScopeAwareRector is ready to be used in custom rules 🎉 🎉 🎉 #2537

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Jun 20, 2022

I think AbstractScopeAwareRector is now ready to be used in custom rector rule, as the next of UnreachableStatementNode is correctly has Scope now, so on this PR, I remove the @internal note comment .

By this, the tweak of PropertyFetch filled outside method which make read after $this->nestingLevel < 2 got UnreachableStatementNode on MultiDirnameRector at PR:

can be rolled back as it no longer error on running rectify:

bin/rector process rules/Php70/Rector/FuncCall/MultiDirnameRector.php --dry-run --clear-cache     
 1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

                                                                                                                        
 [OK] Rector is done!                                                                                                                                                                                                             

🎉 🎉 🎉

@samsonasik samsonasik requested a review from TomasVotruba as a code owner June 20, 2022 11:09
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba
Copy link
Member

Thank you, I agree, let's ship it to public then 😉

@TomasVotruba TomasVotruba merged commit 21fc218 into main Jun 20, 2022
@TomasVotruba TomasVotruba deleted the abstract-scope-aware-is-ready branch June 20, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants