Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Renaming] Do not rename docblock same name not found in use inside namespace #2471

Merged
merged 11 commits into from
Jun 11, 2022

Conversation

samsonasik
Copy link
Member

Closes #2468

@samsonasik samsonasik requested a review from TomasVotruba as a code owner June 10, 2022 07:42
@samsonasik samsonasik force-pushed the close-2468 branch 3 times, most recently from b306e93 to fdecce8 Compare June 10, 2022 08:20
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@samsonasik
Copy link
Member Author

rebased.

@samsonasik
Copy link
Member Author

phpstan notice is unrelated:

Run vendor/bin/phpstan analyse --ansi --error-format symplify
Note: Using configuration file /home/runner/work/rector-src/rector-src/phpstan.neon.
Config file /home/runner/work/rector-src/rector-src/vendor/symplify/phpstan-rules/packages/symfony/config/services.neon does not exist or isn't readable

@samsonasik
Copy link
Member Author

re-trigger CI

@TomasVotruba
Copy link
Member

Missclick :)

Thanks 👍

@TomasVotruba TomasVotruba merged commit a5340c6 into main Jun 11, 2022
@TomasVotruba TomasVotruba deleted the close-2468 branch June 11, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants