Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DX] Detach typo3 from core to allow stable growth of both packages #2446

Merged
merged 5 commits into from
Jun 6, 2022

Conversation

TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Jun 6, 2022

Last 3 months I've been working on upgrade of Rector and it caused me to duplicate lot of work directly in typo3 Rector. The reason is typo3 Rector uses rector/rector-src dev-main. It is very unstable and any commit here can break it. And many times it did :(

On the otherside, the typo3 Rector depens on many external packages, that are not useful for the other rector/rector users. Because of current architecture, they're forced to download it and whole prefixed Rector is shipped with those.

That's stressful for both sides and shows bad architecture.


Instead, external package like should use rector/rector and build on top of that.

There are many existing 3rd party extensions that work well this way:

Please follow their architecture for inspiration.


How to change typo3-rector? Basically it requires change of external dependency and updating related services:

 {
    "require": {
-         "rector/rector-src": "dev-main"
+         "rector/rector": "^0.13.4"
     }
 }

I belive this will allow both packages to grow closer to their domain and help their own communities closer, with their own specific problems 🙏 👍

@TomasVotruba TomasVotruba changed the title tv typo3 detach core [DX] Detach typo3 from core to avoid constant breaking Jun 6, 2022
@TomasVotruba TomasVotruba changed the title [DX] Detach typo3 from core to avoid constant breaking [DX] Detach typo3 from core to allow stable growth of both packages Jun 6, 2022
@TomasVotruba
Copy link
Member Author

TomasVotruba commented Jun 6, 2022

@simonschaufi Hi, I believe you're now maintaining the project, so this is important to upgrade for your next release.
It might require some work, but it will bring more stability for both packages. Let me know if you have some questions 👍

@TomasVotruba
Copy link
Member Author

TomasVotruba commented Jun 6, 2022

I'm merging this, so you can use rector/rector without duplicating the classes.

@TomasVotruba TomasVotruba merged commit bd0104d into main Jun 6, 2022
@TomasVotruba TomasVotruba deleted the tv-typo3-detach-core branch June 6, 2022 17:28
@TomasVotruba
Copy link
Member Author

As a unintentional side effect, Rector build now dropped from 4:50 to 3:40, that's 25 % faster 👍


Before

image


Now

image

@simonschaufi
Copy link
Contributor

I'm just a contributor to the project like @helsner but @sabbelasichon is still the project lead. I didn't take over the project and I don't want that actually 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants