Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Renaming] Keep comment on RenameClassRector #2439

Merged
merged 3 commits into from
Jun 5, 2022

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik requested a review from TomasVotruba as a code owner June 5, 2022 02:09
@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @eigan

@samsonasik
Copy link
Member Author

it seems it cause error in doctrine packages test:

https://github.com/rectorphp/rector-src/runs/6742172295?check_suite_focus=true#step:7:19

@samsonasik
Copy link
Member Author

Fixed 🎉

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit 8b4df18 into main Jun 5, 2022
@TomasVotruba TomasVotruba deleted the keep-comment-rename-class branch June 5, 2022 06:49
@TomasVotruba
Copy link
Member

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression from 0.13.3 -> 0.13.4 with RenameClassRector. Doc comments removed.
2 participants