[DeadCode] Add RemoveJustPropertyFetchRector #2433
Conversation
TomasVotruba
force-pushed
the
tv-remove-just-assign
branch
7 times, most recently
from
d0612de to
14eaec3
Compare
| // ... | ||
| $assign = $stmt->expr; | ||
|
|
||
| if (! $assign->expr instanceof PropertyFetch) { |
There was a problem hiding this comment.
how about static property fetch ?
There was a problem hiding this comment.
In case of static property fetch, some reading/writing/cache is expected, so it would be risky to try to cover it.
This rule covers only readonly property fetch assign.
There was a problem hiding this comment.
Btw, seems like --debug/-vvv option does not work anymore. Only the last error message is printed, not the full stack trace. I tired to downgrade to Symfony 6 but it was not helpful :/
Could you check it? 🙂
There was a problem hiding this comment.
I will try. How to reproduce the not shown stack trace for your use case? throw Exception?
There was a problem hiding this comment.
Yea, I just throw a ShouldNotHappenException to e.g. PhpDocInfoFactory::createFromNodeOrEmpty() on first line.
TomasVotruba
force-pushed
the
tv-remove-just-assign
branch
2 times, most recently
from
3070454 to
bb5cf4b
Compare
TomasVotruba
force-pushed
the
tv-remove-just-assign
branch
from
bb5cf4b to
5498164
Compare
TomasVotruba
force-pushed
the
tv-remove-just-assign
branch
5 times, most recently
from
eb7be57 to
84cc85a
Compare
TomasVotruba
force-pushed
the
tv-remove-just-assign
branch
from
84cc85a to
fddd92e
Compare
TomasVotruba
force-pushed
the
tv-remove-just-assign
branch
from
fddd92e to
ca8e4a7
Compare
No description provided.