Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Renaming] Skip docblock rename different namespace on RenameClassRector #2419

Merged
merged 18 commits into from
Jun 4, 2022
Merged

[Renaming] Skip docblock rename different namespace on RenameClassRector #2419

merged 18 commits into from
Jun 4, 2022

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik requested a review from TomasVotruba as a code owner June 2, 2022 16:57
@samsonasik samsonasik marked this pull request as draft June 2, 2022 17:45
@samsonasik samsonasik force-pushed the skip-rename-docblock-different-namespace branch from 5addb5f to 365cb9c Compare June 2, 2022 18:29
@samsonasik samsonasik marked this pull request as ready for review June 2, 2022 22:26
@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @eigan

@samsonasik
Copy link
Member Author

Temporary pin phpstan to 1.7.8 based on 7dc2885

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@samsonasik samsonasik force-pushed the skip-rename-docblock-different-namespace branch from eed9999 to e916874 Compare June 3, 2022 09:19
@samsonasik
Copy link
Member Author

rebased.

@samsonasik samsonasik force-pushed the skip-rename-docblock-different-namespace branch from e916874 to ae82ef5 Compare June 4, 2022 03:36
@samsonasik
Copy link
Member Author

rebased.

@TomasVotruba
Copy link
Member

Thank you 👍

@TomasVotruba TomasVotruba merged commit 283a9af into main Jun 4, 2022
@TomasVotruba TomasVotruba deleted the skip-rename-docblock-different-namespace branch June 4, 2022 07:32
@eigan
Copy link
Contributor

eigan commented Jun 4, 2022

That was fast! Thanks @samsonasik 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RenameClassRector: Replaces in docblock before looking at imported classes
4 participants
@samsonasik @TomasVotruba @eigan @actions-user