-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Fix bootstrap stubs load on PHP 7.2 when vendor/ excluded via skip() #2394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 30, 2022
All checks have passed 🎉 @TomasVotruba it is ready for review. |
Thanks 👍 Please add a reproducer test, so we have it covered for future. |
samsonasik
force-pushed
the
fix-php72-exclude-vendor-load-stub
branch
2 times, most recently
from
May 30, 2022 13:00
0aa263e
to
9e99442
Compare
I've added e2e test for rector/rector for run under php 7.2 9e99442 |
All checks have passed 🎉 @TomasVotruba I think it is ready. |
samsonasik
force-pushed
the
fix-php72-exclude-vendor-load-stub
branch
from
May 30, 2022 14:09
30179db
to
2da394e
Compare
rebased. |
Thank you 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TomasVotruba this is to fix issue that only happen in PHP 7.2, which can make error:
"Child process error: PHP Fatal error: Class 'ReflectionUnionType' not found
while working on PHP 7.3 and PHP 7.4. Reproduced repository :
https://github.com/Micr0mega/rector-issue-7196/runs/6651988104?check_suite_focus=true#step:5:10
/cc @Micr0mega
Fixes rectorphp/rector#7196