[Core] Add $seconds, $maxNumberOfProcess, and $jobSize parameters to RectorConfig::parallel() method #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was thinking about that, but it might be more easier to find this under parallel() method. We needed this on previous parameters approach, but it was not possible. Could you move it to parallel() method with optional params? Same for the other parallel parameter |
|
I've moved to |
samsonasik
changed the title
|
All checks have passed 🎉 @TomasVotruba I think it is ready. |
|
I've added more params for parallel job size and parallel max number of process, place in 2nd and 3rd param as most of the time, the changed part is the $second parameter. |
samsonasik
changed the title
TomasVotruba
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to handle use Option directly to increase parallel timeout like this codeigniter4/CodeIgniter4@346c83f#diff-d933a2ad57daa43419b483d3f1ddedaec7aa44933007fead9f9437390f596f4a