Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Php74] Allow change protected property of final class when property only in current class on TypedPropertyRector #2153

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clean up
samsonasik committed Apr 24, 2022

Verified

This commit was signed with the committer’s verified signature.
samsonasik Abdul Malik Ikhsan
commit 6b88f3b99e7a14d1185febbd2802e0f1634d2a57
4 changes: 0 additions & 4 deletions rules/Php74/Guard/MakePropertyTypedGuard.php
Original file line number Diff line number Diff line change
@@ -83,10 +83,6 @@ private function isSafeProtectedProperty(Property $property, Class_ $class): boo
return false;
}

if (! $class->extends instanceof FullyQualified) {
return true;
}

return $this->parentPropertyLookupGuard->isLegal($property);
}
}