Add RectorConfig for custom configuration methods and avoid conflicts with Symfony API

[TomasVotruba]

Follow up to #1891

---

Using Symfony container for rector.php configuration is handy for autocomplete, static analysis and re-use of Symfony DI container.
Yet, it has few drawbacks, when it comes to a project that runs on Symfony with it's own Symfony DI. There 2 classes of same name can conflict in IDE and come to an autoloading issue. See rectorphp/rector#7035 for more.

@Wirone came with a great idea, to have an own configurator class, that will be tailored to Rector's needs and features.
Similar to Config Builder Classes from Symfony: https://symfony.com/blog/new-in-symfony-5-3-config-builder-classes

How do we use rector.php now?

use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
use Rector\Core\Configuration\Option;
use Rector\DowngradePhp81\Rector\Property\DowngradeReadonlyPropertyRector;

// ups, possible conflict with ContainerConfigurator
return static function (ContainerConfigurator $containerConfigurator): void {
    $parameters = $containerConfigurator->parameters();

    // too verbose params, constants and possible typo in param value 
    $parameters->set(Option::PATHS, [[ // ups, "[[" typo
        __DIR__.'/src/',
    ]]);

    $services = $containerConfigurator->services();
    $services->set(DowngradeReadonlyPropertyRector::class);
};

How could we use RectorConfig in future?

use Rector\Config\RectorConfig;

return static function (RectorConfig $rectorConfig): void {
    $rectorConfig->parallel();

    $rectorConfig->paths([
        __DIR__.'/src',
    ]);


    $rectorConfig->rule(DowngradeReadonlyPropertyRector::class);
};

[samsonasik]

new e2e directory need to be register to e2e.yaml

rector-src/.github/workflows/e2e.yaml

Lines 25 to 32 in 0a6b3b3

	directory:
	- 'e2e/template-extends'
	- 'e2e/plain-views'
	- 'e2e/parallel-custom-config'
	- 'e2e/parallel-reflection-resolver'
	- 'e2e/no-parallel-reflection-resolver'
	- 'e2e/applied-rule-return-array-nodes'
	- 'e2e/applied-rule-change-docblock'

[samsonasik]

custom config may need to be conditionally checked

rector-src/.github/workflows/e2e.yaml

Lines 53 to 55 in 0a6b3b3

	- run: php ../e2eTestRunner.php -c custom/config/rector.php
	working-directory: ${{ matrix.directory }}
	if: ${{ matrix.directory == 'e2e/parallel-custom-config' }}

[TomasVotruba]

new e2e directory need to be register to e2e.yaml

Hm 🤔 We should automate this with some script.

[samsonasik]

custom config check need to be checked as well

rector-src/.github/workflows/e2e.yaml

Lines 57 to 59 in 0a6b3b3

	- run: php ../e2eTestRunner.php --config custom/config/rector.php
	working-directory: ${{ matrix.directory }}
	if: ${{ matrix.directory == 'e2e/parallel-custom-config' }}

with || condition, ref

https://github.community/t/and-operator-in-if-condition/154825

if: ${{ (matrix.directory == 'e2e/parallel-custom-config') || (matrix.directory == 'e2e/use-rector-configurator')}}

also in line 64 with && condition`

if: ${{ (matrix.directory != 'e2e/parallel-custom-config') &&  (matrix.directory != 'e2e/use-rector-configurator') }}

[TomasVotruba]

@samsonasik > custom config check need to be checked as well

I see. I've just copy-pasted another directory, this can be in the root. I've moved it to avoid this one. Thanks

[TomasVotruba]

After this PR is merged, line needs to update in each Rector split repository's composer.json, so we have the same patched Symfony everywhere

[samsonasik]

target-repository e2e may need update, for example on global install e2e https://github.com/rectorphp/rector-src/tree/main/build/target-repository/e2e/global-install

[samsonasik]

@param mixed[] $paths

may be used when next Assert::allString($paths) is checked.

[TomasVotruba]

👍

[TomasVotruba]

Let's 🚢 it 👍