Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodingStyle] Use alias name when exists on CatchExceptionNameMatchingTypeRector #1920

Merged
merged 3 commits into from
Mar 11, 2022

Conversation

samsonasik
Copy link
Member

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…gTypeRector
@samsonasik
Copy link
Member Author

implemented 🎉 /cc @freiondrej-lmc

@freiondrej-lmc
Copy link

@samsonasik thank you! It's really amazing to see how well Rector's code is written because something like this is so easy to implement. Seeing the code is a great inspiration for writing my own rules :)

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit 07df2bc into main Mar 11, 2022
@TomasVotruba TomasVotruba deleted the use-alias-catch-exception branch March 11, 2022 08:53
@TomasVotruba
Copy link
Member

Thank you @samsonasik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect behavior of CatchExceptionNameMatchingTypeRector
4 participants