Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test for RemoveUselessReturnTagRector #1799

Closed
wants to merge 1 commit into from

Conversation

leighman
Copy link
Contributor

Psalm allows prefixing of tags. Usually these would provide refinement on top of the type so should not be removed

Psalm allows prefixing of tags. Usually these would provide refinement on top of the type so should not be removed
@TomasVotruba
Copy link
Member

Seems legit 👍
Please provide fix so we can merge it

@leighman
Copy link
Contributor Author

Any pointer? I can't get the project running very well locally so it's difficult to play about.
Is it treating the @psalm-return tag as a normal @return tag?

@TomasVotruba
Copy link
Member

Is it treating the @psalm-return tag as a normal @return tag?

Yes 👍

Any pointer? I can't get the project running very well locally so it's difficult to play about.

Probably check the name on the ReturnTagValueNode. It should be in the removal method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants