-
-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TypeDeclaration] Skip use return docblock on typed intersection type #1728
Merged
TomasVotruba
merged 13 commits into
main
from
skip-use-return-doc-on-typed-intersection
Jan 26, 2022
Merged
[TypeDeclaration] Skip use return docblock on typed intersection type #1728
TomasVotruba
merged 13 commits into
main
from
skip-use-return-doc-on-typed-intersection
Jan 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
changed the title
[TypeDeclaration] Skip use return docblock on typed intersection type
[TypeDeclaration] Handle use return docblock on typed intersection type
Jan 25, 2022
samsonasik
force-pushed
the
skip-use-return-doc-on-typed-intersection
branch
from
January 26, 2022 09:45
a75be7f
to
71e52dd
Compare
samsonasik
changed the title
[TypeDeclaration] Handle use return docblock on typed intersection type
[TypeDeclaration] Skip use return docblock on typed intersection type
Jan 26, 2022
samsonasik
force-pushed
the
skip-use-return-doc-on-typed-intersection
branch
from
January 26, 2022 09:47
82a9bbf
to
e54b334
Compare
Fixed 🎉 with skip when in resolved type name is 'string' or 'object' |
All checks have passed 🎉 @TomasVotruba it is ready for review. |
samsonasik
force-pushed
the
skip-use-return-doc-on-typed-intersection
branch
from
January 26, 2022 10:25
c34b181
to
8876d3c
Compare
Thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TomasVotruba this continue PR #1727. Given the following code:
It produce replace return object to string, which invalid: