Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to configure followLinks of finder #1703

Merged
merged 6 commits into from
Jan 24, 2022
Merged

Add option to configure followLinks of finder #1703

merged 6 commits into from
Jan 24, 2022

Conversation

sabbelasichon
Copy link
Contributor

@TomasVotruba
Copy link
Member

Thanks for the PR 👍

What happen when the parameter is set to false?
Could you provide simple test to confirm symlinks are disabled/enabled? Just in case the parameter service or finder change.

@sabbelasichon
Copy link
Contributor Author

@TomasVotruba I have added two simple tests for that

@TomasVotruba
Copy link
Member

Thank you 👏

@TomasVotruba TomasVotruba merged commit 084ac39 into main Jan 24, 2022
@TomasVotruba TomasVotruba deleted the issue-6950 branch January 24, 2022 22:00
@TomasVotruba
Copy link
Member

I've noticed the PHPStan has this enabled by default: phpstan/phpstan-src@0c356a4

So I think it's a way to go to enable it here too 👍

@sabbelasichon
Copy link
Contributor Author

sabbelasichon commented Apr 20, 2022 •
edited
Loading

@TomasVotruba It is enabled by default if the option does not exist. Maybe it is too hard to read

@TomasVotruba
Copy link
Member

I see. Even better then 👍

@TomasVotruba
Copy link
Member

Ref #2112

@TomasVotruba TomasVotruba mentioned this pull request Apr 20, 2022
Merged
@TomasVotruba TomasVotruba mentioned this pull request Jun 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make followLinks for finder configurable
4 participants
@sabbelasichon @TomasVotruba @samsonasik @actions-user