-
-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DX] Avoid reporting deprecated errors #1577
Conversation
71ec35f
to
690556d
Compare
690556d
to
9935d6c
Compare
Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified with check code:
@mkdir('test');
@mkdir('test');
and with the change :
if ((error_reporting() & $code) === 0) {
it run ok, only check error_reporting()
will end up getting error:
[ERROR] Could not process "/Users/samsonasik/www/rector-src/src/Application/FileProcessor.php" file, due to:
"mkdir(): File exists". On line: 26
I created PR to PHPStan for it sync phpstan/phpstan-src#889 |
Also referenced to PHP documentation https://www.php.net/manual/en/language.operators.errorcontrol.php#language.operators.errorcontrol |
Thank you 👍 |
@TomasVotruba it possibly cause error on downgrade, ref https://github.com/rectorphp/rector-src/runs/4643749917?check_suite_focus=true#step:9:9039 [ERROR] Could not process
"phar:///home/runner/work/rector-src/rector-src/vendor/phpstan/phpstan/
phpstan.phar/src/Type/Constant/ConstantStringType.php" file, due to:
"Uninitialized string offset -1". On line: 222 Previously, the It seems |
I created PR #1579 to try fix on stopped by |
No description provided.