Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArrowFunctionToAnonymousFunctionRector - failing test #1512

Closed
wants to merge 1 commit into from
Closed

ArrowFunctionToAnonymousFunctionRector - failing test #1512

wants to merge 1 commit into from

Conversation

ondrejmirtes
Copy link
Contributor

The failure:

Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@

     public function table(int $terminalWidth, int $maxHeaderWidth): void
     {
-        $f = static function ($rows) use ($terminalWidth, $maxHeaderWidth) : array {
+        $f = static function ($rows) : array {
             return array_map(static function ($row) use ($terminalWidth, $maxHeaderWidth) : array {
                 return array_map(static function ($s) use ($terminalWidth, $maxHeaderWidth) {
                     if ($terminalWidth > $maxHeaderWidth + 5) {

samsonasik added a commit that referenced this pull request Dec 17, 2021
@samsonasik
Closes #1512
1297159
@samsonasik samsonasik mentioned this pull request Dec 17, 2021
Merged
@samsonasik
Copy link
Member

@ondrejmirtes it seems because of inside CallLilke, I created PR #1514 for it.

samsonasik added a commit that referenced this pull request Dec 17, 2021
@samsonasik @ondrejmirtes @actions-user
[DowngradePhp74] Handle ArrowFunctionToAnonymousFunctionRector inside…
0c26b04 
… CallLike + preserve byRef (#1514)

* ArrowFunctionToAnonymousFunctionRector - failing test

* Closes #1512

* phpstan

* clean up

* ArrowFunctionToAnonymousFunctionRector - preserve byRef in closure use

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

Co-authored-by: Ondrej Mirtes <ondrej@mirtes.cz>
Co-authored-by: GitHub Action <action@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ondrejmirtes @samsonasik