[DeadCode] Skip clone and new self on RemoveUnusedPrivatePropertyRector

[samsonasik]

Given the following code:

class SkipCloneSelf
{
    private $var;

    public function __construct($var)
    {
        $this->var = $var;
    }

    public function run()
    {
        $obj = clone $this;
        echo $obj->var;
    }

    public function run2($var)
    {
        $obj = new self($var);
        echo $obj->var;
    }
}

It produce:

-    private $var;
-
-    public function __construct($var)
+    public function __construct()
     {
-        $this->var = $var;
     }

which should be skipped, ref https://3v4l.org/jjNe3

[samsonasik]

Fixed 🎉

[samsonasik]

All checks have passed 🎉 @TomasVotruba it is ready for review.

[TomasVotruba]

Could you extract this to own service? The logic seems quite complex

[samsonasik]

implemented, I moved to new service ForbiddenPropertyRemovalAnalyzer 12bf694

[samsonasik]

All checks have passed 🎉 @TomasVotruba I think it is ready.

[TomasVotruba]

Thank you 👍