Add ReturnTypeFromStrictBoolReturnExprRector support for if/else returns

rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictBoolReturnExprRector/Fixture/If_else_bools.php.inc

@@ -0,0 +1,35 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictBoolReturnExprRector\Fixture;
+
+final class IfElseBools
+{
+    public function run($value)
+    {
+        if ($value) {
+            return true;
+        } else {
+            return false;
+        }
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictBoolReturnExprRector\Fixture;
+
+final class IfElseBools
+{
+    public function run($value): bool
+    {
+        if ($value) {
+            return true;
+        } else {
+            return false;
+        }
+    }
+}
+
+?>

rules/TypeDeclaration/NodeAnalyzer/ReturnTypeAnalyzer/AlwaysStrictReturnAnalyzer.php

@@ -7,7 +7,9 @@
 use PhpParser\Node\Expr\Closure;
 use PhpParser\Node\Expr\Yield_;
 use PhpParser\Node\Stmt\ClassMethod;
+use PhpParser\Node\Stmt\Else_;
 use PhpParser\Node\Stmt\Function_;
+use PhpParser\Node\Stmt\If_;
 use PhpParser\Node\Stmt\Return_;
 use Rector\Core\PhpParser\Node\BetterNodeFinder;
 use Rector\TypeDeclaration\NodeAnalyzer\ReturnAnalyzer;
@@ -44,11 +46,30 @@ public function matchAlwaysStrictReturns(ClassMethod|Closure|Function_ $function
             return [];
         }
 
+        // is one in ifOrElse, other in else?
+        $onlyStmt = $functionLike->stmts[0] ?? null;
+        if ($onlyStmt instanceof If_ && $onlyStmt->elseifs === [] && $onlyStmt->else instanceof Else_) {
+            if ($this->hasFirstLevelReturn($onlyStmt) && $this->hasFirstLevelReturn($onlyStmt->else)) {
+                return $returns;
+            }
+        }
+
         // has root return?
         if (! $this->returnAnalyzer->hasClassMethodRootReturn($functionLike)) {
             return [];
         }
 
         return $returns;
     }
+
+    private function hasFirstLevelReturn(If_|Else_ $ifOrElse): bool
+    {
+        foreach ($ifOrElse->stmts as $stmt) {
+            if ($stmt instanceof Return_) {
+                return true;
+            }
+        }
+
+        return false;
+    }
 }