[PHP 8.0] Fix skip of silent key in annotation to attribute (#1932)

rectorphp · Mar 15, 2022 · dc8e8ff · dc8e8ff
1 parent b835233
commit dc8e8ff
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 0 deletions.
diff --git a/packages/PhpAttribute/AttributeArrayNameInliner.php b/packages/PhpAttribute/AttributeArrayNameInliner.php
@@ -9,6 +9,7 @@
 use PhpParser\Node\Expr\ArrayItem;
 use PhpParser\Node\Identifier;
 use PhpParser\Node\Scalar\String_;
+use Rector\Core\Exception\NotImplementedYetException;
 use Webmozart\Assert\Assert;
 
 final class AttributeArrayNameInliner
@@ -66,6 +67,11 @@ private function inlineArray(array $args): array
                 if ($arrayItem->key instanceof String_) {
                     $arrayItemString = $arrayItem->key;
                     $newArgs[] = new Arg($arrayItem->value, false, false, [], new Identifier($arrayItemString->value));
+                } elseif ($arrayItem->key === null) {
+                    // silent key
+                    $newArgs[] = new Arg($arrayItem->value);
+                } else {
+                    throw new NotImplementedYetException(get_debug_type($arrayItem->key));
                 }
             }
         }

diff --git a/...sts/Php80/Rector/Class_/AnnotationToAttributeRector/Fixture/first_param_is_silent.php.inc b/...sts/Php80/Rector/Class_/AnnotationToAttributeRector/Fixture/first_param_is_silent.php.inc
@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\Class_\AnnotationToAttributeRector\Fixture;
+
+use Rector\Tests\Php80\Rector\Class_\AnnotationToAttributeRector\Source\GenericAnnotation;
+
+/**
+ * @GenericAnnotation("sample", itemOperations="yes")
+ */
+final class FirstParamIsSilent
+{
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php80\Rector\Class_\AnnotationToAttributeRector\Fixture;
+
+use Rector\Tests\Php80\Rector\Class_\AnnotationToAttributeRector\Source\GenericAnnotation;
+
+#[GenericAnnotation('sample', itemOperations: 'yes')]
+final class FirstParamIsSilent
+{
+}
+
+?>