[Php81] Skip override __construct from interface on NewInInitializerR…

…ector (#1913)

Co-authored-by: GitHub Action <action@github.com>

packages/FamilyTree/NodeAnalyzer/ClassChildAnalyzer.php

@@ -46,6 +46,9 @@ public function hasParentClassMethod(ClassReflection $classReflection, string $m
         return $this->resolveParentClassMethods($classReflection, $methodName) !== [];
     }
 
+    /**
+     * Look both parent class and interface, yes, all PHP interface methods are abstract
+     */
     public function hasAbstractParentClassMethod(ClassReflection $classReflection, string $methodName): bool
     {
         $parentClassMethods = $this->resolveParentClassMethods($classReflection, $methodName);
@@ -87,18 +90,19 @@ public function resolveParentClassMethodReturnType(ClassReflection $classReflect
     private function resolveParentClassMethods(ClassReflection $classReflection, string $methodName): array
     {
         $parentClassMethods = [];
-        foreach ($classReflection->getParents() as $parentClassReflections) {
-            if (! $parentClassReflections->hasMethod($methodName)) {
+        $parents = array_merge($classReflection->getParents(), $classReflection->getInterfaces());
+        foreach ($parents as $parent) {
+            if (! $parent->hasMethod($methodName)) {
                 continue;
             }
 
-            $methodReflection = $parentClassReflections->getNativeMethod($methodName);
+            $methodReflection = $parent->getNativeMethod($methodName);
             if (! $methodReflection instanceof PhpMethodReflection) {
                 continue;
             }
 
             $methodDeclaringMethodClass = $methodReflection->getDeclaringClass();
-            if ($methodDeclaringMethodClass->getName() === $parentClassReflections->getName()) {
+            if ($methodDeclaringMethodClass->getName() === $parent->getName()) {
                 $parentClassMethods[] = $methodReflection;
             }
         }

rules-tests/Php81/Rector/ClassMethod/NewInInitializerRector/Fixture/skip_override_interface_method.php.inc

@@ -0,0 +1,17 @@
+<?php
+
+namespace Rector\Tests\Php81\Rector\ClassMethod\NewInInitializerRector\Fixture;
+
+use DateTime;
+use Rector\Tests\Php81\Rector\ClassMethod\NewInInitializerRector\Source\OverrideInterfaceMethod;
+
+class SkipOverrideInterfaceMethod implements OverrideInterfaceMethod
+{
+    private DateTime $dateTime;
+
+    public function __construct(
+        ?DateTime $dateTime = null
+    ) {
+        $this->dateTime = $dateTime ?? new DateTime('now');
+    }
+}

rules-tests/Php81/Rector/ClassMethod/NewInInitializerRector/Source/OverrideInterfaceMethod.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Php81\Rector\ClassMethod\NewInInitializerRector\Source;
+
+use DateTime;
+
+interface OverrideInterfaceMethod
+{
+    public function __construct(
+        ?DateTime $dateTime = null
+    );
+}